| Subject: | There are two major problems with... |
| Summary: | Package rating comment |
| Messages: | 2 |
| Author: | Artur Graniszewski |
| Date: | 2010-08-19 09:55:44 |
| Update: | 2010-08-19 18:32:45 |
| |
|
|
Artur Graniszewski rated this package as follows:
| Utility: | Insufficient |
| Consistency: | Insufficient |
| Examples: | Sufficient |
|
|
 Artur Graniszewski - 2010-08-19 09:55:44
There are two major problems with this class:
1) you use $_SESSION for storing and retrieving SQL data, so when you want to clean your cache, you clear entire user session (see session_destroy()) - this is a major problem for most of the homebrew PHP scripts which, and even some advanced (which use custom session handlers and database storage)
2) there is a potential problem with mysql_real_escape, you really should use connection handler in all of your mysql_* functions, because some scripts will be using two or more different MySQL connections (for example with different encodings).
 Pashkov Denis Igorevich - 2010-08-19 18:32:45 - In reply to message 1 from Artur Graniszewski
thank u , i will fix this, it was very basic example, so i don't think about complex projects..
|